[PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver
bp at alien8.de
Thu Dec 3 05:23:49 AEDT 2020
On Thu, Dec 03, 2020 at 01:32:44AM +1030, Andrew Jeffery wrote:
> On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote:
> > Hi Joel,
> > Thanks for the suggestion, I'll fix the review and create an new patch
> > against
> > latest Linux branch. Those exported function will be referenced in
> > other driver yet
> > to be upstream, so should I move those exported functions out of this
> > patch?
> Yes, let's leave the exports out of this patch, and add them in when you send
> the patch that depends on them.
And when you do, almost all new exports are EXPORT_SYMBOL_GPL - not
Also, I'd like to see how those exports are going to be used. An EDAC
driver function exported to another driver sounds strange. We have only
one other case like this in the EDAC tree:
and even that is not really needed...
More information about the Linux-aspeed