[PATCH 2/2] EDAC/ti: Fix handling of platform_get_irq() error
Tero Kristo
t-kristo at ti.com
Thu Aug 27 17:13:16 AEST 2020
On 27/08/2020 10:07, Krzysztof Kozlowski wrote:
> platform_get_irq() returns -ERRNO on error. In such case comparison
> to 0 would pass the check.
>
> Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC")
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
Reviewed-by: Tero Kristo <t-kristo at ti.com>
> ---
> drivers/edac/ti_edac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
> index 6e52796a0b41..e7eae20f83d1 100644
> --- a/drivers/edac/ti_edac.c
> +++ b/drivers/edac/ti_edac.c
> @@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev)
>
> /* add EMIF ECC error handler */
> error_irq = platform_get_irq(pdev, 0);
> - if (!error_irq) {
> + if (error_irq < 0) {
> + ret = error_irq;
> edac_printk(KERN_ERR, EDAC_MOD_NAME,
> "EMIF irq number not defined.\n");
> goto err;
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
More information about the Linux-aspeed
mailing list