AST2600 clock gates

Joel Stanley joel at jms.id.au
Tue Apr 14 18:38:08 AEST 2020


On Mon, 13 Apr 2020 at 00:24, Oskar Senft <osk at google.com> wrote:
>
> OMG, I'm sorry. Ignore. I got confused between ASPEED_CLK_* being random identifiers and ASPEED_RESET_* actually being bits in the registers. Sorry.

No worries. The arragement is not straight forward, I'm glad you worked it out.

I look forward to reviewing your patches on the list :)

Cheers,

Joel

>
> Oskar.
>
> On Sun, Apr 12, 2020 at 7:22 PM Oskar Senft <osk at google.com> wrote:
>>
>> Hey Joel and Andrew
>>
>> I'm working on the AST2600 EVB trying to get some eSPI functionality to work using https://github.com/AspeedTech-BMC/linux/blob/aspeed-dev-v5.1/drivers/soc/aspeed/aspeed-espi.c. The driver is missing support for clock enablement so I dug into how this could be added.
>>
>> I noticed that you guys worked on include/dt-bindings/clock/ast2600-clock.h but from what I can tell the ASPEED_CLK_GATE_* definitions have not yet been updated from AST2500 to AST2600.
>>
>> Am I looking at the latest version of the file? I'm happy to update the clock gate bits, but I don't want to duplicate work that you have in the pipeline.
>>
>> Thanks
>> Oskar.


More information about the Linux-aspeed mailing list