[PATCH] net/ncsi: Disable global multicast filter
vijaykhemka at fb.com
Tue Sep 17 05:26:27 AEST 2019
From: Christian Svensson <bluecmd at google.com>
Date: Monday, September 16, 2019 at 5:33 AM
To: Samuel Mendoza-Jonas <sam at mendozajonas.com>
Cc: Vijay Khemka <vijaykhemka at fb.com>, "David S. Miller" <davem at davemloft.net>, "netdev at vger.kernel.org" <netdev at vger.kernel.org>, "linux-kernel at vger.kernel.org" <linux-kernel at vger.kernel.org>, "openbmc @ lists . ozlabs . org" <openbmc at lists.ozlabs.org>, Joel Stanley <joel at jms.id.au>, "linux-aspeed at lists.ozlabs.org" <linux-aspeed at lists.ozlabs.org>, Sai Dasari <sdasari at fb.com>
Subject: Re: [PATCH] net/ncsi: Disable global multicast filter
On Mon, Sep 16, 2019 at 4:39 AM Samuel Mendoza-Jonas <sam at mendozajonas.com<mailto:sam at mendozajonas.com>> wrote:
> I'll have a look at the multicast issues, CC'ing in Chris too who IIRC
> was looking at similar issues for u-bmc in case he got further.
Thanks. I think this is very similar to the patch that u-bmc has, but this one is an actual nice-looking patch :-). The u-bmc one is just a bunch of #if 0's around multicast filtering.
What I'm worried about is that we forget why IPv6 works by disabling multicast filtering, I don't see any elaborate mention of this in the code. The long-term fix is to make sure the GMF is programmed with the correct multicast groups to make IPv6 happy, and we shouldn't lose track of that I feel. However, as an intermediate fix I welcome this patch whole-heartedly.
Currently issues are with vender’s firmware. If we enable multicast filtering it filters IPV6 packets as well like RA, neighbor discovery etc. And by disabling it forward all packets including IPV6 to management controller.
I will see if I can dig up an eval board to try it on and add a Tested-By in that case.
Thanks Chris, I am looking forward to your test results.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linux-aspeed