[PATCH 02/12] irqchip: Add Aspeed SCU interrupt controller
maz at kernel.org
Mon Nov 11 01:53:12 AEDT 2019
On Fri, 8 Nov 2019 14:18:23 -0600
Eddie James <eajames at linux.ibm.com> wrote:
> The Aspeed SOCs provide some interrupts through the System Control
> Unit registers. Add an interrupt controller that provides these
> interrupts to the system.
> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> MAINTAINERS | 1 +
> drivers/irqchip/Makefile | 2 +-
> drivers/irqchip/irq-aspeed-scu-ic.c | 233 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 235 insertions(+), 1 deletion(-)
> create mode 100644 drivers/irqchip/irq-aspeed-scu-ic.c
> +static int aspeed_scu_ic_map(struct irq_domain *domain, unsigned int irq,
> + irq_hw_number_t hwirq)
> + irq_set_chip_and_handler(irq, &aspeed_scu_ic_chip, handle_simple_irq);
handle_simple_irq is usually wrong, and works badly with threaded
interrupts. I suggest you'd change it to handle_level_irq, which
probably matches the behaviour of the controller.
Otherwise, this looks good.
Jazz is not dead. It just smells funny...
More information about the Linux-aspeed