[PATCH v2 2/2] rtc: Add ASPEED RTC driver
alexandre.belloni at bootlin.com
Tue Mar 26 03:10:10 AEDT 2019
On 25/03/2019 15:28:26+0000, Joel Stanley wrote:
> On Mon, 25 Mar 2019 at 14:59, Alexandre Belloni
> <alexandre.belloni at bootlin.com> wrote:
> > Hi,
> > This seems mostly good to me.
> > On 26/03/2019 00:01:59+1030, Joel Stanley wrote:
> > > + dev_dbg(dev, "%s: %4d-%02d-%02d %02d:%02d:%02d\n", __func__,
> > > + 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
> > > + tm->tm_hour, tm->tm_min, tm->tm_sec);
> > > +
> > We now have %ptR, could you use that?
> I tried this:
> dev_dbg(dev, "%s: %ptR", __func__, tm);
> Yes, that appears to do the job. Can you make the change when applying?
While doing that change, I relaized that the whole locking is probably
unnecessary as all the rtc_ops are called with the rtc lock taken. If
you are not planning to add alarm support, the lock can be removed.
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
More information about the Linux-aspeed