[PATCH v2 2/2] rtc: Add ASPEED RTC driver
joel at jms.id.au
Tue Mar 26 02:28:26 AEDT 2019
On Mon, 25 Mar 2019 at 14:59, Alexandre Belloni
<alexandre.belloni at bootlin.com> wrote:
> This seems mostly good to me.
> On 26/03/2019 00:01:59+1030, Joel Stanley wrote:
> > + dev_dbg(dev, "%s: %4d-%02d-%02d %02d:%02d:%02d\n", __func__,
> > + 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
> > + tm->tm_hour, tm->tm_min, tm->tm_sec);
> > +
> We now have %ptR, could you use that?
I tried this:
dev_dbg(dev, "%s: %ptR", __func__, tm);
Yes, that appears to do the job. Can you make the change when applying?
> > + rtc->rtc_dev->ops = &aspeed_rtc_ops;
> > + rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900;
> > + rtc->rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */
> > +
> I'm curious how many RTC have been properly designed, could you run
It appears to pass the test:
Testing 2000-02-28 23:59:59.
Testing 2038-01-19 03:14:07.
Testing 2069-12-31 23:59:59.
Testing 2099-12-31 23:59:59.
Testing 2100-02-28 23:59:59.
Testing 2106-02-07 06:28:15.
Testing 2262-04-11 23:47:16.
The qemu model I have for the device failed though. A good test! Are
you going to put it in the kernel tree?
More information about the Linux-aspeed