Re: [PATCH 5/8] pinctrl: aspeed: Correct comment that is no longer true
andrew at aj.id.au
Thu Jun 27 13:57:49 AEST 2019
On Thu, 27 Jun 2019, at 13:00, Joel Stanley wrote:
> On Wed, 26 Jun 2019 at 07:16, Andrew Jeffery <andrew at aj.id.au> wrote:
> > We have handled the GFX register case for quite some time now.
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > ---
> > drivers/pinctrl/aspeed/pinctrl-aspeed.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.h b/drivers/pinctrl/aspeed/pinctrl-aspeed.h
> > index 4b06ddbc6aec..c5918c4a087c 100644
> > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.h
> > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.h
> > @@ -240,8 +240,7 @@
> > * opposed to naming them e.g. PINMUX_CTRL_[0-9]). Further, signal expressions
> > * reference registers beyond those dedicated to pinmux, such as the system
> > * reset control and MAC clock configuration registers. The AST2500 goes a step
> AST2600 too?
No mention of the GFX block in the pinctrl table for the 2600, it appears the pinmux
state is entirely determined by SCU registers.
> Acked-by: Joel Stanley <joel at jms.id.au>
> > - * further and references registers in the graphics IP block, but that isn't
> > - * handled yet.
> > + * further and references registers in the graphics IP block.
> > */
> > #define SCU2C 0x2C /* Misc. Control Register */
> > #define SCU3C 0x3C /* System Reset Control/Status Register */
> > --
> > 2.20.1
More information about the Linux-aspeed