[PATCH v1 2/2] soc: nuvoton: add NPCM LPC BPC driver
tmaimon77 at gmail.com
Thu Jun 13 19:26:42 AEST 2019
Adding Patrick and Joel to this discussion,
Thanks for your prompt reply!
On Tue, 11 Jun 2019 at 16:12, Arnd Bergmann <arnd at arndb.de> wrote:
> On Mon, Jun 10, 2019 at 4:19 PM Tomer Maimon <tmaimon77 at gmail.com> wrote:
> > Add Nuvoton BMC NPCM BIOS post code (BPC) driver.
> > The NPCM BPC monitoring two I/O address written by
> > the host on the Low Pin Count (LPC) bus, the capure
> > data stored in 128-word FIFO.
> > Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
> We've run into this situation before, but don't have a good solution yet:
> The driver seems useful and well implemented, but I keep having a bad
> feeling about adding a chardev driver into drivers/soc for something that
> is clearly specific to a particular implementation on the hardware side
> but generic on the user interface. The same user interface might be
> used on an Aspeed BMC or any other one, so please coordinate at
> least between Novoton and Aspeed developers on creating a common
> user interface, and review each other's patches.
Probably the only vendors that will use the snoop will be Nuvoton and
is it worth to create new snoop common user interface for it,
if we will develop a new snoop user interface who will be the maintainer?
> Maybe we can introduce a drivers/bmc/ (or even drivers/openbmc)
that collects all those user interfaces with a thin abstraction layer
> and one or two hardware specific back-ends?
Sounds good, Maybe we can move the KCS BMC from driver/char/ipmi to the
appreciate your opinions, Joel, Andrew and Patrick?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linux-aspeed