[RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings

Wang, Haiyue haiyue.wang at linux.intel.com
Sat Jul 27 03:30:24 AEST 2019

在 2019-07-26 13:39, Andrew Jeffery 写道:
> The v2 bindings allow us to extract the resources from the devicetree.
> The table in the driver is retained to derive the channel index, which
> removes the need for kcs_chan property from the v1 bindings. The v2
> bindings allow us to reduce the number of warnings generated by the
> existing devicetree nodes.
> Cc: Haiyue Wang<haiyue.wang at linux.intel.com>
> Cc: Corey Minyard<minyard at acm.org>
> Cc: Arnd Bergmann<arnd at arndb.de>
> Cc: Greg Kroah-Hartman<gregkh at linuxfoundation.org>
> Cc:openipmi-developer at lists.sourceforge.net
> Signed-off-by: Andrew Jeffery<andrew at aj.id.au>
> ---
>   drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------
>   1 file changed, 127 insertions(+), 29 deletions(-)

Looks good, thanks for the hard work, the code is more clean! :)

Reviewed-by: Haiyue Wang <haiyue.wang at linux.intel.com>

More information about the Linux-aspeed mailing list