[PATCH] dt-bindings: pinctrl: aspeed: Fix 'compatible' schema errors
joel at jms.id.au
Tue Jul 16 09:16:54 AEST 2019
On Mon, 15 Jul 2019 at 22:37, Rob Herring <robh at kernel.org> wrote:
> The Aspeed pinctl schema have errors in the 'compatible' schema:
> Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml: \
> properties:compatible:enum: ['aspeed', 'ast2400-pinctrl', 'aspeed', 'g4-pinctrl'] has non-unique elements
> Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml: \
> properties:compatible:enum: ['aspeed', 'ast2500-pinctrl', 'aspeed', 'g5-pinctrl'] has non-unique elements
> Flow style sequences have to be quoted if the vales contain ','. Fix
> this by using the more common one line per entry formatting.
> - enum: [ aspeed,ast2400-pinctrl, aspeed,g4-pinctrl ]
> + enum:
> + - aspeed,ast2400-pinctrl
> + - aspeed,g4-pinctrl
Thanks for the fix. However, we've standardised on the first form for
all of our device trees, so we can drop the second compatible string
from the bindings.
I think Andrew already has a patch cooking to do this.
More information about the Linux-aspeed