[PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace

Greg KH gregkh at linuxfoundation.org
Wed Aug 21 22:39:33 AEST 2019

On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote:
> Modules using these symbols are required to explicitly import the
> namespace. This patch was generated with the following steps and serves
> as a reference to use the symbol namespace feature:
>  1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols
>     in watchdog_core.c
>  2) make  (see warnings during modpost about missing imports)
>  3) make nsdeps
> I used 'allmodconfig' for the above steps to ensure all occurrences are
> patched.
> Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this
> case as not only watchdog_core is defined in drivers/watchdog/Makefile.
> Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros
> to export into a different namespace.
> An alternative to this patch would be a single definition line before
> any use of EXPORT_SYMBOL*:
> Signed-off-by: Matthias Maennich <maennich at google.com>

As we talked in chat, the cc: list for this patch was crazy :)

If you end up resending this (as odds are the mailing lists will trash
it for too many recipients), feel free to add:

Reviewed-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Great work,

greg k-h

More information about the Linux-aspeed mailing list