Re: [PATCH] pinctrl: aspeed: g6: Remove const specifier from aspeed_g6_sig_expr_set's ctx parameter
andrew at aj.id.au
Wed Aug 7 10:36:00 AEST 2019
On Wed, 7 Aug 2019, at 10:02, Nathan Chancellor wrote:
> clang errors:
> drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2325:9: error: incompatible
> pointer types initializing 'int (*)(struct aspeed_pinmux_data *, const
> struct aspeed_sig_expr *, bool)' with an expression of type 'int (const
> struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)'
> .set = aspeed_g6_sig_expr_set,
> 1 error generated.
> Commit 674fa8daa8c9 ("pinctrl: aspeed-g5: Delay acquisition of regmaps")
> changed the set function pointer declaration and the g6 one wasn't
> updated (I assume because it wasn't merged yet).
> Fixes: 2eda1cdec49f ("pinctrl: aspeed: Add AST2600 pinmux support")
> Link: https://github.com/ClangBuiltLinux/linux/issues/632
> Signed-off-by: Nathan Chancellor <natechancellor at gmail.com>
That's exactly what happened. Thanks.
Reviewed-by: Andrew Jeffery <andrew at aj.id.au>
More information about the Linux-aspeed