[PATCH 1/4] mtd: spi-nor: aspeed: use command mode for reads

Cédric Le Goater clg at kaod.org
Fri Sep 21 16:09:11 AEST 2018


On 09/21/2018 04:39 AM, Joel Stanley wrote:
> Hello Mark,
> 
> On Mon, 23 Jul 2018 at 21:42, Joel Stanley <joel at jms.id.au> wrote:
>>
>> On 22 June 2018 at 21:44, Cédric Le Goater <clg at kaod.org> wrote:
>>> When reading flash contents, try to use the "command mode" if the AHB
>>> window configured for the flash module is big enough. Else, just fall
>>> back to the "user mode" to perform the read.
>>>
>>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
>>
>> Reviewed-by: Joel Stanley <joel at jms.id.au>
> 
> Are you waiting on anything from Cedric or myself for this series. If
> not, can we please get them queued for 4.20?

There is one typo on the definition of the timing register of the AST2400
SPI controller we should fix. It can come later. Apart from that, I don't 
see any changes I would like to do. May be a couple of variable renames to 
clarify the loop on the hclk cycles and delays to fit the U-Boot driver
which was proposed recently. Please tell me :)

Thanks,

C. 


More information about the Linux-aspeed mailing list