[PATCH 5/5] serial/aspeed-vuart: Implement quick throttle mechanism

Jeremy Kerr jk at ozlabs.org
Wed Mar 21 14:32:27 AEDT 2018

Hi Joel,

> The diff is a bit confusing, considering you just added these
> functions. Can you explain why you did it that way?

Sure. The initial versions were the standard callbacks for struct
uart_ops, which all need to take the port lock.

Patch 5/5 needs a lockless version of these for calling from the irq
handler, which already has the lock held. So, we introduce the
__-versions there.

I could add the lockless version in the earlier 4.5 patch, but it looks
a bit redundant there. Happy to go either way. Or, I can elaborate why
in the commit log (I'll need a v2 anyway for the setup_timer change...).



More information about the Linux-aspeed mailing list