[PATCH v2 0/4] watchdog: aspeed: Retain enabled state and move to arch_initcall

Andrew Jeffery andrew at aj.id.au
Wed Sep 20 15:30:16 AEST 2017


Hello,

This series fixes some issues with the Aspeed watchdog, as outlined in the
v1[1] cover letter.

I've added a bit of an explanation as to why we call aspeed_wdt_start() in
probe() if the watchdog is already enabled, but the essence of it is to ensure
the watchdog is configured to the expectations of the kernel driver (rather
than however the bootloader configured it).

Please review!

Andrew

Since v1:

* Rework patch 1/4 to simply remove the writel() call to restore the original
  behaviour.
* Rework patch 4/4 to remove the Kconfig changes to retain the ability to build
  the watchdog as a module, and add the exit handler.

[1] https://lkml.org/lkml/2017/9/18/14

Andrew Jeffery (4):
  watchdog: aspeed: Retain watchdog enabled state
  watchdog: aspeed: Fix 'Apseed' typo in Kconfig
  watchdog: aspeed: Remove specific reference to AST2400 in Kconfig
  watchdog: aspeed: Move init to arch_initcall

 drivers/watchdog/Kconfig      |  4 ++--
 drivers/watchdog/aspeed_wdt.c | 21 ++++++++++++++++++---
 2 files changed, 20 insertions(+), 5 deletions(-)

-- 
2.11.0



More information about the Linux-aspeed mailing list