[Lguest] should lg_cpu.ssh1 be u16 ?
Rusty Russell
rusty at rustcorp.com.au
Mon May 25 17:02:33 EST 2009
On Sun, 24 May 2009 04:56:05 am Matias Zabaljauregui wrote:
> Rusty,
>
> I just realized that our ss1 member in lg_cpu is u8.
> I guess this is not an issue with Linux because it always stores
> __KERNEL_DS (index for the 13th GDT entry) so 8 bits are enough. But I'm
> asking myself what happens if the kernel data segment descriptor gets moved
> to some higher GDT entry or we get to support other guests some day?
Yes, Linux defined GDT_ENTRIES to 32, and we only handle that many.
If we ever changed that, this could become a problem. This takes no more
space, so I'll apply your patch.
Thanks!
Rusty.
More information about the Lguest
mailing list