[Lguest] Question about DEFINE_MUTEX(lguest_lock) location

Rusty Russell rusty at rustcorp.com.au
Tue Feb 24 13:59:15 EST 2009


On Friday 20 February 2009 14:32:19 Atsushi SAKAI wrote:
> Hi,
> 
> I have a question about "DEFINE_MUTEX(lguest_lock)" location.
> 
> Since lguest_lock defines on drivers/lguest/core.c
> But it uses only on drivers/lguest/lguest_user.c
> 
> I think it should be move the definition location on lguest_lock,
> from core.c to lguest_user.c.
> 
> Is there any reason DEFINE_MUTEX on core.c?

If it can be static, it should be.  We can always move it back if someone else
needs access to it.

Please send a patch!
Rusty.



More information about the Lguest mailing list