[Lguest] [PATCH] next-20090730 lguest build breaks with pfn_pmd()

Rusty Russell rusty at rustcorp.com.au
Tue Aug 4 09:21:31 EST 2009


On Sat, 1 Aug 2009 03:33:56 am Randy Dunlap wrote:
> On Thu, 30 Jul 2009 17:35:33 +0530 Kamalesh Babulal wrote:
> > @@ -984,14 +984,14 @@ static unsigned long setup_pagetables(struct lguest *lg,
> >  	for (i = j = 0; i < mapped_pages && j < PTRS_PER_PMD;
> >  	     i += PTRS_PER_PTE, j++) {
> >  		pmd = pfn_pmd(((unsigned long)&linear[i] - mem_base)/PAGE_SIZE,
> > -			      _PAGE_PRESENT | _PAGE_RW | _PAGE_USER);
> > +			      __pgrot(_PAGE_PRESENT | _PAGE_RW | _PAGE_USER));
> 
> s/__pgrot/__pgprot/

Damn, sorry.  I threw this patch in linux-next and went skiing.

Kamalesh said:

"I have tested the patch for the build failure only."

This was clearly untrue.  Don't do that again, or I'll just ignore your
emails.

Rusty.


More information about the Lguest mailing list