[Lguest] [PATCH 4/5] lguest: use KVM hypercalls

Christian Borntraeger borntraeger at de.ibm.com
Wed Apr 15 19:07:05 EST 2009


Am Wednesday 15 April 2009 10:47:17 schrieb Herbert Xu:
> tun: Fix sk_sleep races when attaching/detaching
>
> As the sk_sleep wait queue actually lives in tfile, which may be
> detached from the tun device, bad things will happen when we use
> sk_sleep after detaching.
>
> Since the tun device is the persistent data structure here (when
> requested by the user), it makes much more sense to have the wait
> queue live there.  There is no reason to have it in tfile at all
> since the only time we can wait is if we have a tun attached.
> In fact we already have a wait queue in tun_struct, so we might
> as well use it.
>
> Reported-by: Christian Borntraeger <borntraeger at de.ibm.com>
> Reported-by: Eric W. Biederman <ebiederm at xmission.com>
> Reported-by: Patrick McHardy <kaber at trash.net>
> Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>

Tested-by: Christian Borntraeger <borntraeger at de.ibm.com>



More information about the Lguest mailing list