[Lguest] [PATCH] Fix booting pentium+ with dodgy TSC

Ingo Molnar mingo at elte.hu
Sun Apr 6 21:22:08 EST 2008


* Rusty Russell <rusty at rustcorp.com.au> wrote:

> Linus please apply.  Almost by definition this patch can't make things 
> worse.

well, while i agree with the patch it could make things worse. In this 
case it can cause code that has been compiled to rely on TSC to 
malfunction. For if sched_clock() was using cpu_has_tsc it could return 
0 all the time, breaking the scheduler without the user having a clear 
idea why it broke. It isnt, and sched_clock() will work fine, but still, 
your "this cant make things worse" statement is not completely correct. 

In any case:

 Acked-by: Ingo Molnar <mingo at elte.hu>

and i've also queued it up into the for-.25 queue of x86.git.

	Ingo



More information about the Lguest mailing list