[Lguest] [kvm-devel] [PATCH 3/6] virtio net driver

Herbert Xu herbert at gondor.apana.org.au
Sat Sep 22 00:08:33 EST 2007


On Fri, Sep 21, 2007 at 02:36:43PM +0200, Christian Borntraeger wrote:
>
> @@ -335,7 +344,7 @@ static void *virtnet_probe(struct device
>  	dev->poll = virtnet_poll;
>  	dev->hard_start_xmit = start_xmit;
>  	dev->weight = 16;
> -	dev->features = NETIF_F_HIGHDMA;
> +	dev->features = NETIF_F_HIGHDMA | NETIF_F_LLTX;
>  	SET_NETDEV_DEV(dev, device);
>  
>  	/* Do we support "hardware" checksums? */

Please don't use LLTX in new drivers.  We're trying to get rid
of it since it's

1) unnecessary;
2) causes problems with AF_PACKET seeing things twice.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the Lguest mailing list