[Lguest] [kvm-devel] [PATCH 3/6] virtio net driver

Christian Borntraeger borntraeger at de.ibm.com
Fri Sep 21 20:48:11 EST 2007


Am Donnerstag, 20. September 2007 schrieb Rusty Russell:
> The network driver uses *two* virtqueues: one for input packets and
> one for output packets.  This has nice locking properties (ie. we
> don't do any for recv vs send).
[...]
> 	3) Resolve freeing of old xmit skbs (someone sent patch IIRC?)

Yes, that was me. I am quite busy at the moment but I will send a refreshed 
patch soon. The most annoying fact of my current patch is, that I have to add 
locking. (Because of the only one operation per virtqueue at a time rule)

[...]
> +struct virtnet_info
> +{
> +	struct virtqueue_ops *vq_ops;
> +	struct virtqueue *vq_recv;
> +	struct virtqueue *vq_send;
> +	struct net_device *ndev;

This is only a matter of taste, but I like netdev or dev more than ndev.

[...]

Everything else looks sane.

20-minutes-code-review-by: Christian Borntraeger <borntraeger at de.ibm.com>

Christian




More information about the Lguest mailing list