[Lguest] [PATCH 7/24] consolidate msr.h
Bastian Blank
bastian at waldi.eu.org
Tue Nov 20 09:21:51 EST 2007
On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote:
> - wrmsrl(MSR_CSTAR, ia32_cstar_target);
> + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target);
Hmm, why do you add explicit casts? The compiler should convert that
correctly on its own.
> +static inline void wrmsrl(unsigned int msr, unsigned long long val)
Hmm, long long is 64 bit on all x86, but why not use explicit u64 to
show that?
Bastian
--
Captain's Log, star date 21:34.5...
More information about the Lguest
mailing list