[Lguest] [PATCH 01/16] introduce vcpu struct
    Rusty Russell 
    rusty at rustcorp.com.au
       
    Wed Dec 26 10:34:05 EST 2007
    
    
  
On Friday 21 December 2007 00:33:41 Glauber de Oliveira Costa wrote:
> this patch introduces a vcpu struct for lguest. In upcoming patches,
> more and more fields will be moved from the lguest struct to the vcpu
Hi Glommer,
> +static inline struct lguest *lg_of_vcpu(struct lguest_vcpu *vcpu)
> +{
> +	return container_of((vcpu - vcpu->vcpu_id), struct lguest, vcpus[0]);
> +}
I think this function is a bad idea: it contains implicit UP assumptions which 
aren't obvious to the caller.  vcpu->lg should do the same thing, no?
Rusty,
    
    
More information about the Lguest
mailing list