[Lguest] [patch] cleanup hypercall code

[Jes Sorensen]

ron minnich wrote:
> On 8/17/07, Jes Sorensen <jes at sgi.com> wrote:
> 
>> --- linux-2.6.23-rc3.orig/include/linux/lguest.h
>> +++ linux-2.6.23-rc3/include/linux/lguest.h
>> @@ -36,7 +36,7 @@ struct lguest_data
>>         /* 0xFF == done (set by Host), 0 == pending (set by Guest). */
>>         u8 hcall_status[LHCALL_RING_SIZE];
>>         /* The actual registers for the hypercalls. */
>> -       struct hcall_ring hcalls[LHCALL_RING_SIZE];
>> +       struct hcall_args hcalls[LHCALL_RING_SIZE];
>                                      ^^^^^^
> 
> The size parameter is a ring size. instead of hcalls, how about
> calling it hcall_ring? So it's clearly a ring of hcall_args? Just
> wondering.

Hi Ron,

I'm not really biased for the name, I see the name as size == number of
entries, so in that case it should be ok.

> Jes, are you folks at SGI looking at the 64 bit guest? Just wondering
> ... I am going to be using 64 bit plan 9 guests this fall I hope.

Well, we as in me at SGI, then yes. However we're interested in a
slightly different 64 bit port than most people, ie. the ia64 port, not
the x86_64 one.

Cheers,
Jes