[Lguest] [patch] core.c i386 disentangle
Jes Sorensen
jes at sgi.com
Fri Aug 17 00:54:40 EST 2007
Muli Ben-Yehuda wrote:
> Hey Jes, just something I caught while browsing through the patch:
>
> On Thu, Aug 16, 2007 at 04:38:12PM +0200, Jes Sorensen wrote:
>
>> Index: linux-2.6.23-rc3/drivers/lguest/i386_core.c
>> ===================================================================
>> --- /dev/null
>> +++ linux-2.6.23-rc3/drivers/lguest/i386_core.c
>
> [snip]
>
>> +int lguest_arch_deliver_trap(struct lguest *lg)
>> +{
>> + /* If we get here, it's a trap the Guest wants to know
>> + * about. */
>> + if (deliver_trap(lg, lg->regs->trapnum))
>> + continue;
>
> That `continue' looks pretty bogus.
Hmmm,
Not sure, might be my blind copy-paste of Rusty's code from the loop.
May have to do a return with a status code or something like that.
My brain has turned to mush - something for tomorrow.
Thanks,
Jes
More information about the Lguest
mailing list