[Lguest] [patch] lguest_dma.c

Jes Sorensen jes at sgi.com
Fri Aug 10 19:00:13 EST 2007


Steven Rostedt wrote:
>> +int lguest_bind_dma(unsigned long key, struct lguest_dma *dmas,
>> +		    unsigned int num, u8 irq)
>> +{
>> +	/* This is the only hypercall which actually wants 5 arguments, and we
>> +	 * only support 4.  Fortunately the interrupt number is always less
>> +	 * than 256, so we can pack it with the number of dmas in the final
>> +	 * argument.  */
>> +	if (!hcall(LHCALL_BIND_DMA, key, __pa(dmas),
>> +		   (num << LGUEST_IRQ_SHIFT) | irq))
>> +		return -ENOMEM;
>> +	return 0;
>> +}
>> +
> 
> I guess we should have num as an unsigned long.

Probably a good idea, I'll update the patch for the next version.

Cheers,
Jes





More information about the Lguest mailing list