[Lguest] [PATCH 4/25] [PATCH] Add debugreg/load_rsp native hooks

[Jeremy Fitzhardinge]

Andi Kleen wrote:
>> @@ -264,13 +270,64 @@ struct thread_struct {
>>  	set_fs(USER_DS);							 \
>>  } while(0)
>>
>> -#define get_debugreg(var, register)				\
>> -		__asm__("movq %%db" #register ", %0"		\
>> -			:"=r" (var))
>> -#define set_debugreg(value, register)			\
>> -		__asm__("movq %0,%%db" #register		\
>> -			: /* no output */			\
>> -			:"r" (value))
>> +static inline unsigned long native_get_debugreg(int regno)
>> +{
>> +	unsigned long val;
>>     
>
> It would be better to have own functions for each debug register I think
>   

?  A separate pvop for each?  Seems excessive.  And surely this should
be identical to 32bit either way.

    J