[RFC] [PATCH 1/3] of: irq: rename of_irq_count to of_irq_valid_count

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Thu May 30 20:28:12 EST 2013


On 23:25 Wed 29 May     , Grant Likely wrote:
> On Tue, 28 May 2013 17:08:47 +0200, Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> > as we count valid mapped irq not just present irq
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> 
> Hmmm, even with it being in-accurately named, I think it is dangerous to
> rename the existing function and re-use the old name. Anyone with
> out-of-tree code will get the behaviour changed under their feet. I
> think it would be better to drop this patch from the series.

after think I known this can be consider as noisy change but I think we could
rename it anyway to make it more clear and use a different name as you propose for the counting irq
in PATCH 2/3

Best Regards,
J.


More information about the devicetree-discuss mailing list