[net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support
David Miller
davem at davemloft.net
Sun May 26 16:42:48 EST 2013
From: Mugunthan V N <mugunthanvnm at ti.com>
Date: Thu, 23 May 2013 18:00:23 +0530
> From: Hebbar Gururaja <gururaja.hebbar at ti.com>
>
> Amend cpsw controller to optionally take a pin control handle and set
> the state of the pins to:
>
> - "default" on boot, resume
> - "sleep" on suspend()
>
> This should make it possible to optimize energy usage for the pins
> for the suspend/resume cycle.
>
> If any of the above pin states are missing in dt, a warning message
> about the missing state is displayed.
> If certain pin-states are not available, to remove this warning message
> pass respective state name with null phandler.
>
> Signed-off-by: Hebbar Gururaja <gururaja.hebbar at ti.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
This still needs some work:
> + /*
> + * Since we continue even when pinctrl node is not found,
> + * Invalidate pins as not available. This is to make sure that
> + * IS_ERR(pins_xxx) results in failure when used.
> + */
The second, third, fourth, and fifth lines are not tabbed correctly. They
should all be two TABs and a SPACE.
Secondly, comments in the networking are to be formatted:
/* Like
* this.
*/
More information about the devicetree-discuss
mailing list