[net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

David Miller davem at davemloft.net
Fri May 24 05:10:37 EST 2013


From: "Hebbar, Gururaja" <gururaja.hebbar at ti.com>
Date: Thu, 23 May 2013 11:28:38 +0000

> On Thu, May 23, 2013 at 12:27:41, David Miller wrote:
>> From: Mugunthan V N <mugunthanvnm at ti.com>
>> Date: Tue, 21 May 2013 15:24:58 +0530
>> 
>> > +		priv->pins_default = pinctrl_lookup_state(priv->pinctrl,
>> > +						PINCTRL_STATE_DEFAULT);
>> 
>> This is not indented correctly.
>> 
>> Argument on the second, and subsequent, lines of a function call
>> must start at the first column after the openning parenthesis of
>> the function call itself.
> 
> Well, if I am correct, doing so will make the line cross 80 character limit.
> If you could (please I ask), can you let me know how it can be handled in 
> above situation. I will make the changes/corrections and re-send it.
> 
> Thanks a lot in advance.

Avoid the deep indentation by coding the basic block into a helper
function.


More information about the devicetree-discuss mailing list