[PATCH v2] mtd: fsmc_nand: fix error return code in fsmc_nand_probe()
Wei Yongjun
weiyj.lk at gmail.com
Tue May 14 12:30:19 EST 2013
From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
Fix to return -ENODEV in the dma channel request error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
---
v1 -> v2: set ret for error cases only
---
drivers/mtd/nand/fsmc_nand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
index 0e5a1d9..95e1768 100644
--- a/drivers/mtd/nand/fsmc_nand.c
+++ b/drivers/mtd/nand/fsmc_nand.c
@@ -1035,12 +1035,14 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
host->read_dma_chan = dma_request_channel(mask, filter,
pdata->read_dma_priv);
if (!host->read_dma_chan) {
+ ret = -ENODEV;
dev_err(&pdev->dev, "Unable to get read dma channel\n");
goto err_req_read_chnl;
}
host->write_dma_chan = dma_request_channel(mask, filter,
pdata->write_dma_priv);
if (!host->write_dma_chan) {
+ ret = -ENODEV;
dev_err(&pdev->dev, "Unable to get write dma channel\n");
goto err_req_write_chnl;
}
More information about the devicetree-discuss
mailing list