[PATCH 1/2] ARM: EXYNOS: Add PCIe driver support

Kukjin Kim kgene.kim at samsung.com
Thu Mar 7 12:17:15 EST 2013


Thomas Petazzoni wrote:
> 
> Dear Thomas Abraham,
> 
> On Mon, 4 Mar 2013 16:01:59 +0530, Thomas Abraham wrote:
> > On 4 March 2013 15:52, Jingoo Han <jg1.han at samsung.com> wrote:
> > > Exynos5440 has two PCIe controllers which can be used as Root Complex.
> > > This driver supports the PCIe controllers as Root Complex mode.
> > >
> > > Signed-off-by: Surendranath Gurivireddy Balla
> <suren.reddy at samsung.com>
> > > Signed-off-by: Siva Reddy Kallam <siva.kallam at samsung.com>
> > > Signed-off-by: Jingoo Han <jg1.han at samsung.com>
> > > ---
> > >  .../devicetree/bindings/pci/exynos-pcie.txt        |   58 ++
> > >  arch/arm/Kconfig                                   |    2 +
> > >  arch/arm/mach-exynos/Kconfig                       |    8 +
> > >  arch/arm/mach-exynos/Makefile                      |    2 +
> > >  arch/arm/mach-exynos/include/mach/pcie.h           |  146 +++
> > >  arch/arm/mach-exynos/pcie.c                        | 1009
> ++++++++++++++++++++
> >
> > Is there any reason to place this code in arch/arm/...? As you know,
> > there is a constant effort to relocate as much code as possible from
> > arch/arm/mach-exynos. So there must be a strong justification for
> > keeping this code in arch/arm/mach-exynos.
> 
> Indeed. Thierry Reding (doing the Tegra PCIe driver) and myself (doing
> the Marvell PCIe driver) are putting our drivers in drivers/pci/host/,
> in agreement with the PCI maintainers.
> 
I agree.

Jingoo, please move this stuff into drivers/pci when you address comments.

Thanks.

- Kukjin



More information about the devicetree-discuss mailing list