[PATCH v6 5/5] ARM: dts: Add FIMD DT binding Documentation
Kukjin Kim
kgene.kim at samsung.com
Thu Mar 7 10:56:23 EST 2013
Sylwester Nawrocki wrote:
>
> On 03/06/2013 10:13 PM, Sylwester Nawrocki wrote:
> > @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = {
> > #ifdef CONFIG_S5P_DEV_FIMD0
> > static struct resource s5p_fimd0_resource[] = {
> > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> > + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"),
> > + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"),
> > };
>
> Oops, something missing here. Of course should be:
>
> @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = {
> #ifdef CONFIG_S3C_DEV_FB
> static struct resource s3c_fb_resource[] = {
> [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K),
> - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"),
^^^^^^^
BTW, can you use 'tab' instead of white space at mark '^'
- Kukjin
More information about the devicetree-discuss
mailing list