[PATCH] ARM: bcm281xx: Add L2 cache enable code

[Arnd Bergmann]

On Tuesday 05 March 2013, Christian Daudt wrote:
> On 13-03-05 01:01 AM, Arnd Bergmann wrote:
> > On Tuesday 05 March 2013, Christian Daudt wrote:
> > For other firmware interfaces like this, we tend to list the specific commands
> > that the firmware understands. If you think there might be different versions
> > to consider, you might want to model this like
> >
> > Documentation/devicetree/bindings/arm/psci.txt
> This interface is stable and in shipping products at this time, and so 
> the api will remain constant.

But what about future products? Wouldn't they be able to extend the
current interface in a compatible way?

> >> +static void __init init_irq(void)
> >> +{
> >> +	irqchip_init();
> >> +	bcm_kona_smc_init();
> >> +
> >> +#ifdef CONFIG_CACHE_L2X0
> >> +	kona_l2_cache_init();
> >> +#endif /* CONFIG_CACHE_L2X0 */
> >> +}
> > Why are you calling bcm_kona_smc_init() and kona_l2_cache_init() from init_irq()?
> >
> > It seems completely unrelated to interrupt handling.
> >
> It was originally in init_machine section but I was told that that was 
> too late and init_irq would be better, and I saw that highbank also has 
> it in init_irq. I agree that it is unrelated to irq - is there a better 
> place to put this in ?

IMHO the later the better. Do you know what issues were caused  by having it
in init_machine?

	Arnd