[PATCH v4 1/2] dma: imx-dma: Add oftree support

Arnd Bergmann arnd at arndb.de
Sun Mar 3 09:12:38 EST 2013


On Saturday 02 March 2013, Markus Pargmann wrote:
> Adding devicetree support for imx-dma driver. Use driver name for
> function 'imx_dma_is_general_purpose' because the devicename for
> devicetree initialized devices is different.
 
Just one small comment this time:

> @@ -734,8 +757,9 @@ static int imxdma_alloc_chan_resources(struct dma_chan *chan)
>  	struct imxdma_channel *imxdmac = to_imxdma_chan(chan);
>  	struct imx_dma_data *data = chan->private;
>  
> -	if (data != NULL)
> +	if (data != NULL) {
>  		imxdmac->dma_request = data->dma_request;
> +	}
>  
>  	while (imxdmac->descs_allocated < IMXDMA_MAX_CHAN_DESCRIPTORS) {
>  		struct imxdma_desc *desc;

I assume that this change wasn't meant to be in here.

	Arnd


More information about the devicetree-discuss mailing list