[PATCH] <linux/of_platform.h>: fix compilation warnings with DT disabled

Rob Herring robherring2 at gmail.com
Sat Mar 2 00:46:23 EST 2013


On 03/01/2013 01:09 AM, Simon Horman wrote:
> On Tue, Feb 19, 2013 at 02:58:25AM +0300, Sergei Shtylyov wrote:
>> Fix the following compilation warnings (in Simon Horman's renesas.git repo):
>>
>> In file included from arch/arm/mach-shmobile/setup-r8a7779.c:24:0:
>> include/linux/of_platform.h:107:13: warning: ‘struct of_device_id’ declared
>> inside parameter list [enabled by default]
>> include/linux/of_platform.h:107:13: warning: its scope is only this definition
>> or declaration, which is probably not what you want [enabled by default]
>> include/linux/of_platform.h:107:13: warning: ‘struct device_node’ declared
>> inside parameter list [enabled by default]
>>
>> <linux/of_platform.h> only #include's headers with definitions of the above
>> mentioned structures if CONFIG_OF_DEVICE=y but uses them even if not. One
>> solution is to move some #include's out of #ifdef CONFIG_OF_DEVICE and use
>> incomplete declarations for the rest of the structures where the #ifdef move
>> doesn't help...
>>
>> Reported-by: Vladimir Barinov <vladimir.barinov at cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
> 
> Reviewed-by: Simon Horman <horms+renesas at verge.net.au>
> 
> Grant, could you consider taking this patch?

Yes, I can, but I don't seem to have the original patch. Can you send it
again.

>> ---
>> Actually, it compiles eve without 'struct device_node' declared, I haven't
>> found the reason of this, so left it there...

device.h has a forward declaration of it.

Rob


More information about the devicetree-discuss mailing list