[PATCH v3] Add OLPC AP-SP input driver

[Dmitry Torokhov]

On Fri, Jun 28, 2013 at 01:15:35PM -0600, Daniel Drake wrote:
> On Fri, Jun 28, 2013 at 12:20 PM, Dmitry Torokhov
> <dmitry.torokhov at gmail.com> wrote:
> >> +static void olpc_apsp_close(struct serio *port)
> >> +{
> >> +     struct olpc_apsp *priv = port->port_data;
> >> +     unsigned int tmp;
> >> +
> >> +     if (--priv->open_count == 0) {
> >
> > Both need locking. It looks like you need the song and dance similar to
> > what i8042 has to do with it's multiplexed ports. Or ps2mult.c...
> 
> I thought they would both be locked already, due to this comment in serio.c:
> 
> /* called from serio_driver->connect/disconnect methods under serio_mutex */
> 
> Or am I missing something there?

Hmm, you are right... I'll add a comment there to remind myself.

-- 
Dmitry