[PATCH] mmc: sh_mobile_sdhi: fix error return code in sh_mobile_sdhi_probe()
Chris Ball
cjb at laptop.org
Fri Jun 28 00:57:52 EST 2013
Hi Wei,
On Tue, May 28 2013, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> Fix to return a negative error code instead of 0 when we cannot get
> IRQ source by platform_get_irq(), as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> ---
> drivers/mmc/host/sh_mobile_sdhi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index cc4c872..a4316b3 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> @@ -273,8 +273,10 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
> }
>
> /* There must be at least one IRQ source */
> - if (!i)
> + if (!i) {
> + ret = irq;
> goto eirq;
> + }
> }
>
> dev_info(&pdev->dev, "%s base at 0x%08lx clock rate %u MHz\n",
Thanks, pushed to mmc-next for 3.11.
- Chris.
--
Chris Ball <cjb at laptop.org> <http://printf.net/>
One Laptop Per Child
More information about the devicetree-discuss
mailing list