[PATCH] leds: Add device tree binding for pca9633

Tony Lindgren tony at atomide.com
Thu Jun 27 17:21:52 EST 2013


* Bryan Wu <cooloney at gmail.com> [130626 16:53]:
> On Wed, Jun 26, 2013 at 7:17 AM, Tony Lindgren <tony at atomide.com> wrote:
> > @@ -22,6 +22,7 @@
> >  #include <linux/i2c.h>
> >  #include <linux/workqueue.h>
> >  #include <linux/slab.h>
> > +#include <linux/of.h>
> >  #include <linux/platform_data/leds-pca9633.h>
> >
> >  /* LED select registers determine the source that drives LED outputs */
> > @@ -93,6 +94,61 @@ static void pca9633_led_set(struct led_classdev *led_cdev,
> >         schedule_work(&pca9633->work);
> >  }
> >
> > +#ifdef CONFIG_OF
> 
> Shall we use "#if IS_ENABLED(CONFIG_OF)", as Grant pointed out recently.

Thanks will do, I'll also add the push-pull vs totem pole binding
as that can be quite crucial for some hardware configurations.

Regards,

Tony


More information about the devicetree-discuss mailing list