[PATCH -next] pwm: samsung: fix return value check in pwm_samsung_probe()

Wei Yongjun weiyj.lk at gmail.com
Wed Jun 26 19:56:06 EST 2013


On 06/26/2013 05:46 PM, Thierry Reding wrote:
> On Wed, Jun 26, 2013 at 06:55:18AM +0800, Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>>
>> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
>> and never returns NULL. The NULL test in the return value check should
>> be replaced with IS_ERR().
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>> ---
>>  drivers/pwm/pwm-samsung.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> Missed another one of those. Given that this isn't merged yet, would you
> mind if Tomasz and/or Kukjin squash it into their patch?

It's OK to me.




More information about the devicetree-discuss mailing list