[PATCH RESEND 1/1] ARM: dts: AM33XX: Add LCDC info into am335x-evm

Jan Lübbe jlu at pengutronix.de
Tue Jun 25 16:50:43 EST 2013


On Mon, 2013-06-24 at 15:32 -0500, Benoit Parrot wrote:
> Add LCDC device node in DT for am33xx
> Add LCDC and Panel info in DT for am335x-evm

> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 0423298..40d7a3f 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -102,6 +136,16 @@
>  				reg = <0x48>;
>  			};
>  		};
> +
> +		lcdc {
> +			compatible = "ti,am33xx-tilcdc";
> +			reg = <0x4830e000 0x1000>;
> +			interrupt-parent = <&intc>;
> +			interrupts = <36>;
> +			ti,hwmods = "lcdc";
> +			ti,allow-non-reduced-blanking-modes;
> +			status = "okay";
> +		};
>  	};
>  
>  	vbat: fixedregulator at 0 {
>  /include/ "tps65910.dtsi"
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 8e1248f..05b2c4a 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -415,5 +415,14 @@
>  			#size-cells = <1>;
>  			status = "disabled";
>  		};
> +
> +		lcdc: lcdc at 4830e000 {
> +			compatible = "ti,am33xx-tilcdc";
> +			reg = <0x4830e000 0x1000>;
> +			interrupt-parent = <&intc>;
> +			interrupts = <36>;
> +			ti,hwmods = "lcdc";
> +			status = "disabled";
> +		};
>  	};
>  };

am335x-evm.dts includes am33xx.dtsi, so you shouldn't need to provide
all SoC-specific settings again in the board dts. The way it's done
here, you get two nodes ("lcdc" and "lcdc at 4830e000") for the same HW
module.

It seems you just need status and maybe
ti,allow-non-reduced-blanking-modes (for which I didn't see either the
binding or the driver code yet).

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the devicetree-discuss mailing list