[PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

Stephen Boyd sboyd at codeaurora.org
Sat Jun 22 03:45:35 EST 2013


On 06/21/13 08:56, Thomas Gleixner wrote:
>
>> +static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id)
>> +{
>> +	struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
> What kind of construct is this?
>
> You are using request_percpu_irq() and the device id is pointing to
> per cpu memory. Why do you need this horrible pointer indirection?
>
> Because a lot of other ARM code uses the same broken construct?

This is an artifact of the ARM local timer API. I have been trying for a
few months to remove the API but I need my first two patches to go
through the tip/timers tree. Please accept them so we don't have this
construct anymore.

https://lkml.org/lkml/2013/6/3/584

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation



More information about the devicetree-discuss mailing list