[PATCH V6 3/3] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC
Jingoo Han
jg1.han at samsung.com
Thu Jun 20 18:40:13 EST 2013
On Thursday, June 20, 2013 5:00 PM, Thomas Petazzoni wrote:
>
> Dear Jingoo Han,
>
> On Thu, 20 Jun 2013 16:57:32 +0900, Jingoo Han wrote:
>
> > > > - pinctrl {
> > > > + pin_ctrl: pinctrl {
> > > > compatible = "samsung,exynos5440-pinctrl";
> > >
> > > I know I'm nitpicking, but isn't this change completely unrelated to
> > > PCIe support?
> >
> > This change is related to PCIe support.
> > Without this, I cannot use gpio binding.
> >
> > This change was guided by Thomas Abraham (Author of Samsung pinctrl).
> > Also, it was confirmed by Kukjin Kim (Maintainer of Samsung SoC).
> >
> > Thank you for your caring. :)
>
> I mean, the change is fine for sure, but it should maybe part of a
> separate patch as it is more a fix than really the introduction of the
> PCIe controller node, as the patch title suggests. This would also for
> example allow this fix to be merged right now (for 3.11), regardless of
> what happens for the rest of your PCIe patches.
>
CC'ed Tomasz Figa
OK, I see.
I will separate this patch to two patches, as Tomasz Figa mentioned.
(http://www.spinics.net/lists/linux-samsung-soc/msg19639.html)
Thank you.
Best regards,
Jingoo Han
More information about the devicetree-discuss
mailing list