[PATCH REBASE] i2c-designware: make SDA hold time configurable

Andy Shevchenko andy.shevchenko at gmail.com
Tue Jun 18 20:32:23 EST 2013


On Mon, Jun 17, 2013 at 11:55 PM, Rob Herring <robherring2 at gmail.com> wrote:

>> +Optional properties :
>> + - sda-hold-time : should contain the SDA hold time in nanoseconds.
>
> Please specify time units in the property name. Perhaps
> i2c-sda-hold-time-ns.
>
> Based on reading the discussion, there is one similar property I have
> found: "samsung,i2c-sda-delay = <100>". I wouldn't copy it as it doesn't
> tell the units or what the delay is.

Often on of the painful issues with DT models is the absence of the properties.
Should someone create the property definition first under
Documentation and _then_ patch everything around?
(Though I think better to think and create documents first and after
program accordingly)

--
With Best Regards,
Andy Shevchenko


More information about the devicetree-discuss mailing list