[PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()

Philipp Zabel p.zabel at pengutronix.de
Tue Jun 18 20:03:26 EST 2013


Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> 
> Add the missing unlock before return from function coda_stop_streaming()
> in the error handling case.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> ---
>  drivers/media/platform/coda.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> index df4ada88..2c3cd17 100644
> --- a/drivers/media/platform/coda.c
> +++ b/drivers/media/platform/coda.c
> @@ -1347,6 +1347,7 @@ static int coda_stop_streaming(struct vb2_queue *q)
>  	if (coda_command_sync(ctx, CODA_COMMAND_SEQ_END)) {
>  		v4l2_err(&dev->v4l2_dev,
>  			 "CODA_COMMAND_SEQ_END failed\n");
> +		mutex_unlock(&dev->coda_mutex);
>  		return -ETIMEDOUT;
>  	}
>  	mutex_unlock(&dev->coda_mutex);
> 
> 

Thanks! If you don't mind, I'll integrate this change into the "[media]
coda: add CODA7541 decoding support" for v2.

regards
Philipp



More information about the devicetree-discuss mailing list