[RFC PATCH v3 2/2] drivers: mfd: vexpress: add Serial Power Controller (SPC) support

Nicolas Pitre nicolas.pitre at linaro.org
Fri Jun 14 10:21:29 EST 2013


On Thu, 13 Jun 2013, Olof Johansson wrote:

> > +	u32 status = readl_relaxed(info->baseaddr + PWC_STATUS);
> 
> Why readl_relaxed() here? Can't you use a normal readl()?

Unfortunately, on ARM readl_relaxed() _is_ the normal readl() because 
the actual readl() may have side effects.  See commit 79f64dbf68c8.


Nicolas


More information about the devicetree-discuss mailing list