[PATCH v3] ethernet/arc/arc_emac - Add new driver
Andy Shevchenko
andy.shevchenko at gmail.com
Fri Jun 14 05:16:48 EST 2013
On Thu, Jun 13, 2013 at 9:33 PM, Joe Perches <joe at perches.com> wrote:
> On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
>> On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
>> <Alexey.Brodkin at synopsys.com> wrote:
>> > Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
>> > instantiated in some legacy ARC (Synopsys) FPGA Boards such as
>> > ARCAngel4/ML50x.
>> > +++ b/drivers/net/ethernet/arc/arc_emac.h
> []
>> > + if (unlikely((info & OWN_MASK) == FOR_EMAC)) {
>> > + /* BD is still owned by EMAC */
>> > + continue;
>> > + }
>>
>> Redundant braces.
>
> Maybe not. Braces can be a visual aid when there is
> a comment in the test.
I'm okay with both approaches. If author considers the comment is
useful in that form, I agree with him.
--
With Best Regards,
Andy Shevchenko
More information about the devicetree-discuss
mailing list