[PATCH v5 01/22] pinctrl: generic: Add DT bindings

Linus Walleij linus.walleij at linaro.org
Wed Jun 12 19:24:38 EST 2013


On Wed, Jun 12, 2013 at 12:22 AM, Laurent Pinchart
<laurent.pinchart+renesas at ideasonboard.com> wrote:

> Document DT properties for the generic pinctrl parameters and add a
> parser function.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>

It appears we have a race here, as something like three people,
or four, happened to do generic pinconf bindings at the same time.

Yesterday I applied Heiko Stübners patch
"pinctrl: add function to parse generic pinconfig properties from a dt node"
doing basically the same thing. With subtle differences...
but it already supports schmittrigging and some more.

It appears to be close to your idea though!

Would it be possible for you to look at what I have on my "devel" branch
now (same as submitted for -next), rebase on that and patch any problems?

> +               if (param->flag) {
> +                       ret = of_property_read_bool(np, param->property)
> +                           ? 0 : -EINVAL;
> +                       val = 1;
> +               } else {
> +                       ret = of_property_read_u32(np, param->property, &val);
> +               }

This construct is done differently in Heiko's code, please
review it so we know we have a nice, efficient parser.

Yours,
Linus Walleij


More information about the devicetree-discuss mailing list